-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed style of enter grade link #68
Changed style of enter grade link #68
Conversation
For UI changes, it would be handy to have a screen shot with the PR in the future. |
Hi
Input is placed inside button, i dont now why?
|
722787a
to
a4cea4b
Compare
Thanks for the explanation. I think we should then create a common class for both i.e. |
@carsongee I am working on this PR |
7659c9a
to
8956a7f
Compare
@amir-qayyum-arbisoft I just noticed you pushed a bunch of commits with the same commit message. That makes it really hard to figure out what you're doing. I know that sometimes you can end up with more commits than you intended -- in those situations you can squash them (edX has docs on this; I frequently use this guide myself) |
@pdpinch i will gona sqash these commits, just testing different scenarios, thanks for these documents |
a504458
to
a38eb92
Compare
{% trans "Enter grade" %} | ||
<% } %> | ||
</a> | ||
<a class="enter-grade-button button" href="#{{ id }}-enter-grade"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: two space index
e7c06ce
to
2f0d436
Compare
@carsongee done with changes and rebase |
color: #333346; | ||
font-weight: bold; | ||
font-size: 0.8125em; | ||
margin-top: 1px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…some spaces in css attributes
c125331
to
00db211
Compare
@carsongee done with 1px fix |
Awesome, thanks so much @amir-qayyum-arbisoft 🎇 |
Changed style of enter grade link
Changed enter grade link style to make it look like button.
#15