Skip to content

Commit

Permalink
search facet accessibility fixes (#1698)
Browse files Browse the repository at this point in the history
* set color of facet drawer caret to silverGrayDark by default

* set collapsed facet contents to visibility: hidden

* fix style linting issue

* use descendent selector instead of child selector

* update course-search-utils

* also hide search input on filterable facets
  • Loading branch information
gumaerc authored Oct 16, 2024
1 parent 50e17e1 commit 984eacb
Show file tree
Hide file tree
Showing 3 changed files with 1,401 additions and 3,080 deletions.
2 changes: 1 addition & 1 deletion frontends/mit-learn/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
},
"dependencies": {
"@ebay/nice-modal-react": "^1.2.13",
"@mitodl/course-search-utils": "^3.1.6",
"@mitodl/course-search-utils": "^3.2.5",
"@remixicon/react": "^4.2.0",
"@sentry/react": "^7.57.0",
"@tanstack/react-query": "^4.36.1",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ const FacetStyles = styled.div`
margin-bottom: 14px;
i {
color: ${({ theme }) => theme.custom.colors.silverGrayLight};
color: ${({ theme }) => theme.custom.colors.silverGrayDark};
}
&:hover i {
Expand Down Expand Up @@ -216,6 +216,16 @@ const FacetStyles = styled.div`
}
}
.facets:not(.facets-expanded, .facets-transitioning):has(
button.filter-section-button
) {
div.facet-visible,
div.facet-list,
div.input-wrapper {
visibility: hidden;
}
}
.filterable-facet {
.facet-list {
max-height: 400px;
Expand Down
Loading

0 comments on commit 984eacb

Please sign in to comment.