Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock file maintenance #2042

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 20, 2023

Mend Renovate

This PR contains the following updates:

Update Change
lockFileMaintenance All locks refreshed

🔧 This Pull Request updates lock files to use the latest dependency versions.


Configuration

📅 Schedule: Branch creation - "before 4am on monday" in timezone US/Eastern, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch 4 times, most recently from d2b1e62 to e4c42f0 Compare December 21, 2023 07:50
@renovate renovate bot changed the title Lock file maintenance chore(deps): lock file maintenance Dec 21, 2023
@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch 2 times, most recently from 9ecb9bd to 4d5d974 Compare December 21, 2023 14:10
@blarghmatey
Copy link
Member

The failing JS test is due to changes in the moment dependency. The 2.29.2 release changes how locales are loaded, and the representation that is being rendered appears to be the Romanian version of "January", which leads me to believe that the locale is not being properly set.

@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch 2 times, most recently from a1c1cf5 to 121392d Compare December 21, 2023 19:28
@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch 10 times, most recently from 785a92a to 9b531d6 Compare January 10, 2024 15:15
@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch 8 times, most recently from 901f155 to 3d4e220 Compare January 19, 2024 20:11
@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch 4 times, most recently from 9850795 to d814c19 Compare January 24, 2024 20:03
@renovate renovate bot changed the title chore(deps): lock file maintenance Lock file maintenance Jan 25, 2024
@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch 3 times, most recently from 9801570 to 8ec406e Compare February 1, 2024 17:29
@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch 8 times, most recently from 8ff5ec6 to 36d0e30 Compare February 5, 2024 22:48
Copy link
Contributor Author

renovate bot commented Feb 6, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@ChristopherChudzicki
Copy link
Contributor

ChristopherChudzicki commented Feb 7, 2024

MomentJS

The failing JS test is due to changes in the moment dependency. The 2.29.2 release changes how locales are loaded, and the representation that is being rendered appears to be the Romanian version of "January", which leads me to believe that the locale is not being properly set.

The dependency was previously ^2.29.4, so I don't think 2.29.2 was the problem. I changed the dep to 2.29.4 so we'll still be using that version, but won't update to the recently-released 2.30.x

@types/react

We were also getting a build error from the staff dashboard because of conflicting @types/react versions.

Many of our dependencies in this repo specify @types/react: * as a dependency; we specify @types/react: ^17 to match the react version we use in staff dashboard. For details, see

Ideally, our deps would specify @types/react: * as a peer-dependency, so that they would defer to our version rather than installing their own. In some cases, newer (major) versions of our dependencies do specify @types/react in this way. So this issue would probably improve with sufficient updates.

In the meantime, I forced yarn to resolve to @types/react: 17.

@@ -14,5 +14,8 @@
"redux-query": "3.3.1",
"redux-query-interface-superagent": "3.3.1",
"redux-query-react": "3.3.1"
},
"resolutions": {
"@types/react": "^17"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A limitation of this is that yarn resolutions must be specified in the root package.json. So if we had differing versions of react (we do) AND multiple both versions used typescript (they don't) this could be problematic.

@ChristopherChudzicki ChristopherChudzicki merged commit eb8576c into main Feb 7, 2024
3 checks passed
This was referenced Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants