Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix font size of course name on Course certificate #2439

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Fix font size of course name on Course certificate #2439

merged 2 commits into from
Nov 6, 2024

Conversation

cp-at-mit
Copy link
Contributor

@cp-at-mit cp-at-mit commented Nov 4, 2024 •
edited
Loading

What are the relevant tickets?

https://github.com/mitodl/hq/issues/5844

Description (What does it do?)

Updates the sizing of the course name font.

Screenshots (if appropriate):

Screenshot 2024-11-01 at 3 36 39 PM

How can this be tested?

  1. Enroll yourself into a course.
  2. Create a Signatory and Course certificate page in the CMS for the course from step 1.
  3. Enter Django Admin and create yourself a course certificate for the course in step 1.
  4. Go to your MITx Online Dashboard. Click on view certificate.
  5. Resize the browser window so that it matches the size in the issue or attached screenshot.

@cp-at-mit cp-at-mit marked this pull request as ready for review November 4, 2024 19:11
@annagav annagav self-assigned this Nov 4, 2024
@annagav annagav self-requested a review November 4, 2024 19:18
annagav
annagav requested changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@annagav annagav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am seeing this:

Screenshot 2024-11-05 at 7 39 41 AM

annagav
annagav approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@annagav annagav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cp-at-mit cp-at-mit merged commit 14db291 into main Nov 6, 2024
7 checks passed
@cp-at-mit cp-at-mit deleted the 5844-certificate-display-on-mobile branch November 6, 2024 11:33
@odlbot odlbot mentioned this pull request Nov 6, 2024
Merged
2 tasks
@cp-at-mit cp-at-mit restored the 5844-certificate-display-on-mobile branch November 8, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annagav annagav annagav approved these changes

Assignees

@annagav annagav

Labels
Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cp-at-mit @annagav