Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.83.1 #1058

Merged
merged 6 commits into from
Jan 27, 2023
Merged

Release 1.83.1 #1058

merged 6 commits into from
Jan 27, 2023

Commits on Jan 23, 2023

  1. change TS config to target ES6 modules (#1044)

    tldr: Changing `module` config changes the syntax used to import/export in the compiled code. The new value, "ES6", means that the code compiled by TS will include import/export statements. That code is then further compiled by Webpack, which removes the imports/exports during concatenation.
    
    Using ES6 import/exports in the typescript output improves Webpack's tree-shaking. (Or really...enables it. I believe webpack does not treeshake unless the input uses ES6 import/export syntax.)
    
    Related:
    
    TS has several sort of settings related to the syntax used in output:
    
    - `lib`: determines the default/builtin type definitions that are included when typechecking your code.
    - `target`: Spcecies environment in which your code is going to run, and controls how Typescript downlevels your code.
    
        > "The `target` setting changes which JS features are downleveled and which are left intact. For example, an arrow function `() => this` will be turned into an equivalent function expression if target is ES5 or lower."
    
        `target` determines the default value of `lib`. If `target` is ES5, you probably want `lib` to be ES5, too, unless you're doing further transpilation with another tool (like babel).
    - `module`: Determines the syntax used for exports.
    - `moduleResolution` determines how module identifiers ("some/thing" in  like `import x from "some/thing"`) are interpretted.
    ChristopherChudzicki authored Jan 23, 2023
    Configuration menu
    Copy the full SHA
    9299447 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5a5c3cc View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Configuration menu
    Copy the full SHA
    98f7c4d View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. refactor: old course theme removed (#1051)

    * refactor: old course theme removed
    
    * removed some old course theme files from base theme
    MAbdurrehman12 authored Jan 25, 2023
    Configuration menu
    Copy the full SHA
    fa5a438 View commit details
    Browse the repository at this point in the history
  2. remove 4 deps included in nanogallery2 (#1054)

    Nanogallery2 includes hammerjs, screenfull, shifty, and images loaded as modules embedded in its source code; see https://github.com/nanostudio-org/nanogallery2/blob/d6056652705360e19ab330095f489f438a9e9d1c/src/jquery.nanogallery2.core.js#L11-L15.
    
    In browsers, Nanogallery2 intends to expose those objects on the global Window.
    
    However, bundling with Webpack messes up the way Nanogallery2 exposes those objects. (NG checks if `exports` is undefined, but Webpack defines an `eports` object itself.) Consequently, naive inclusion of Nanogallery2 in a webpack build does not work.
    
    To work around this, we previously were including those 4 dependencies separately and manually attaching them to global Window object, which is the workaround suggested at nanostudio-org/nanogallery2#98 (comment).
    
    This approach has several downsides, e.g:  extra js; need to make sure we are including the correct versions of the 4 dependencies.
    
    A cleaner approach is to use imports-loader, as suggested nanostudio-org/nanogallery2#98 (comment).
    ChristopherChudzicki authored Jan 25, 2023
    Configuration menu
    Copy the full SHA
    1a3c895 View commit details
    Browse the repository at this point in the history
  3. Release 1.83.1

    odlbot committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    0f3abad View commit details
    Browse the repository at this point in the history