Updates to the backend to support the frontend #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents app API - The basket/add_discount API didn't have the discount code option visible in the schema; fixed - Added the start_checkout to the API spec (as best I could I think) - Updated basket item serializer to include the applied discount information - Regenerate the spec
cp-at-mit
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
https://github.com/mitodl/hq/issues/5656
Description (What does it do?)
Changes some stuff to make things work better for the frontend code:
start_checkoutAPI to the OpenAPI specstart_checkoutAPI to be a view function so it's easier to route and generate docs forHow can this be tested?
Tests should pass. You should see the start checkout API in Swagger, you should be able to see the discount code property the add discount API, and baskets should include discount information if there is any for the items within.
This branch is necessary to make this PR in the frontend repo work, so you can test by checking that out and then using the frontend.