Add option to rename facts

[JamieScottC]

Description

• This adds an input field to a fact source card which allows the ability to rename facts name/trait
• Also removes any weird behavior when deleting values from a fact. Previously values wouldn't be deleted or they would be, but it wouldn't be reflected on the UI.

Type of change

• New feature (non-breaking change which adds functionality)
• Bug fix

How Has This Been Tested?

I have tried editing multiple fact names and then refreshed to make sure the changes are saved

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code

[sonarcloud]

Please retry analysis of this Pull-Request directly on SonarCloud.

[JamieScottC]

Also just pushed another commit to hopefully fix any weird behavior when deleting values from a fact.

[morinjmit]

Is it possible to just make the name field thats already there editable when a user clicks on a fact? So like instead of adding another input below the fact name to change can you make the top one able to be edited? If not maybe hide the top one when the edit window is open just so the fact name isn't showing up twice which could be a little confusing or less straight forward to the user.

Other than that looks good to me

[JamieScottC]

Is it possible to just make the name field thats already there editable when a user clicks on a fact? So like instead of adding another input below the fact name to change can you make the top one able to be edited? If not maybe hide the top one when the edit window is open just so the fact name isn't showing up twice which could be a little confusing or less straight forward to the user.

Other than that looks good to me

Good point! Just pushed that change

[morinjmit]

Looks good now!

[clenk]

LGTM

[JamieScottC]

I just committed another fix for a bug that @elegantmoose noticed. Hopefully one of the last🤞!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here