Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Rich logging and build warning #2893

Merged
merged 9 commits into from
Feb 21, 2024
Merged

Conversation

elegantmoose
Copy link
Contributor

@elegantmoose elegantmoose commented Feb 21, 2024

Description

Added Rich logging to Caldera console logging output. Uses default color scheme. Future logging changes can also use console markup if desired.

Additionally, color settings do abide by the $NO_COLOR env variable setting.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@elegantmoose elegantmoose requested a review from clenk February 21, 2024 03:24
@elegantmoose
Copy link
Contributor Author

elegantmoose commented Feb 21, 2024

Sample output from running server.py without --build flag on first start.

Screenshot from 2024-02-20 22-51-06

@elegantmoose
Copy link
Contributor Author

elegantmoose commented Feb 21, 2024

Closes #2876

@elegantmoose
Copy link
Contributor Author

FYSA @bjeffries

@elegantmoose elegantmoose merged commit 2e0b418 into master Feb 21, 2024
5 of 10 checks passed
@elegantmoose elegantmoose deleted the mkouremetis/logging branch February 21, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants