Skip to content
This repository has been archived by the owner on Jul 3, 2020. It is now read-only.

DNM: Reverted db to store control impact as float #86

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

samcornwell
Copy link
Collaborator

Reverted db to store control impact as float.
Fixed bug due to inconsistent descriptions json from the inspec tool (inspec/inspec#3682).

…istent descriptions json from the inspec tool.
@samcornwell samcornwell requested review from robthew and aaronlippold and removed request for robthew December 20, 2018 18:22
@samcornwell samcornwell changed the title Reverted db to store control impact as float DNM: Reverted db to store control impact as float Dec 20, 2018
@samcornwell
Copy link
Collaborator Author

Do Not Merge for the time being

@samcornwell samcornwell changed the title DNM: Reverted db to store control impact as float Reverted db to store control impact as float Dec 21, 2018
@samcornwell
Copy link
Collaborator Author

should be good to merge now if approved

@samcornwell samcornwell changed the title Reverted db to store control impact as float DNM: Reverted db to store control impact as float Jan 3, 2019
@samcornwell
Copy link
Collaborator Author

Do Not Merge for now. I think I should probably revert the changes I made to descriptions because it seems that they are going to change inspec to match the way @robthew originally wrote it here in heimdall.

inspec/inspec#3682 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant