Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splunk2HDF Updates #2675

Merged
merged 61 commits into from
Mar 18, 2022
Merged

Splunk2HDF Updates #2675

merged 61 commits into from
Mar 18, 2022

Conversation

camdenmoors
Copy link
Collaborator

@camdenmoors camdenmoors commented Feb 28, 2022 •
edited
Loading

  • Supporting older InSpecJS formats with descriptions missing e.g Good NGINX Results
  • Adding insecure mode
  • Adding logging
  • Switch to using https://github.com/splunk/splunk-sdk.js for splunk2hdf
  • document help on heimdall2 splunk config expectations - gui / md
  • throw better error and display than login when its cors, uri, or something not really user/pass
  • allow switching search index
  • allow general searches
  • allow save to splunk fron heimdall
  • Write support documentation

Fixes mitre/saf#175 mitre/saf#174 mitre/saf#172 mitre/saf#171

Related mitre/saf#154

@camdenmoors
Don't assume descriptions is defined
948e984 
Supporting an older format of the InSpec Schema
@camdenmoors camdenmoors temporarily deployed to heimdall2-splunkupdates-afujyf February 28, 2022 18:18 Inactive
@camdenmoors camdenmoors temporarily deployed to heimdall2-splunkupdates-afujyf February 28, 2022 18:42 Inactive
@camdenmoors camdenmoors temporarily deployed to heimdall2-splunkupdates-afujyf February 28, 2022 19:37 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Feb 28, 2022

This pull request introduces 1 alert when merging 6a6b689 into 5f9480d - view on LGTM.com

new alerts:

  • 1 for Disabling certificate validation

@camdenmoors camdenmoors temporarily deployed to heimdall2-splunkupdates-afujyf February 28, 2022 21:13 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Feb 28, 2022

This pull request introduces 1 alert when merging 1029179 into 5f9480d - view on LGTM.com

new alerts:

  • 1 for Disabling certificate validation

@camdenmoors camdenmoors temporarily deployed to heimdall2-splunkupdates-afujyf February 28, 2022 21:22 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Feb 28, 2022

This pull request introduces 1 alert when merging b2d9632 into 5f9480d - view on LGTM.com

new alerts:

  • 1 for Disabling certificate validation

@camdenmoors camdenmoors temporarily deployed to heimdall2-splunkupdates-afujyf February 28, 2022 22:08 Inactive
@camdenmoors camdenmoors marked this pull request as ready for review February 28, 2022 22:12
@lgtm-com
Copy link

lgtm-com bot commented Feb 28, 2022

This pull request introduces 1 alert when merging ea4f2a0 into 5f9480d - view on LGTM.com

new alerts:

  • 1 for Disabling certificate validation

@camdenmoors camdenmoors temporarily deployed to heimdall2-splunkupdates-afujyf February 28, 2022 22:14 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Feb 28, 2022

This pull request introduces 1 alert when merging 6a05eba into 5f9480d - view on LGTM.com

new alerts:

  • 1 for Disabling certificate validation

@camdenmoors camdenmoors temporarily deployed to heimdall2-splunkupdates-afujyf February 28, 2022 22:38 Inactive
@camdenmoors camdenmoors temporarily deployed to heimdall2-splunkupdates-afujyf February 28, 2022 22:40 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Feb 28, 2022

This pull request introduces 1 alert when merging 985e647 into 5f9480d - view on LGTM.com

new alerts:

  • 1 for Disabling certificate validation

@camdenmoors camdenmoors temporarily deployed to heimdall2-splunkupdates-afujyf February 28, 2022 23:10 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Feb 28, 2022

This pull request introduces 1 alert when merging 5efb07e into 5f9480d - view on LGTM.com

new alerts:

  • 1 for Disabling certificate validation

@camdenmoors camdenmoors temporarily deployed to heimdall2-splunkupdates-re1ury March 14, 2022 19:43 Inactive
@camdenmoors camdenmoors requested a review from georgedias March 14, 2022 21:52
@camdenmoors camdenmoors temporarily deployed to heimdall2-splunkupdates-re1ury March 15, 2022 17:09 Inactive
@camdenmoors camdenmoors temporarily deployed to heimdall2-splunkupdates-re1ury March 15, 2022 17:28 Inactive
@camdenmoors camdenmoors temporarily deployed to heimdall2-splunkupdates-re1ury March 15, 2022 17:29 Inactive
@camdenmoors camdenmoors temporarily deployed to heimdall2-splunkupdates-re1ury March 15, 2022 17:33 Inactive
@camdenmoors camdenmoors temporarily deployed to heimdall2-splunkupdates-re1ury March 15, 2022 17:56 Inactive
@camdenmoors camdenmoors temporarily deployed to heimdall2-splunkupdates-re1ury March 17, 2022 17:08 Inactive
@camdenmoors camdenmoors temporarily deployed to heimdall2-splunkupdates-re1ury March 17, 2022 17:35 Inactive
@camdenmoors camdenmoors temporarily deployed to heimdall2-splunkupdates-re1ury March 18, 2022 16:22 Inactive
@camdenmoors camdenmoors added the ready-to-merge Used by mergify to identify if a PR is ready to merge into master. label Mar 18, 2022
@camdenmoors camdenmoors temporarily deployed to heimdall2-splunkupdates-re1ury March 18, 2022 16:31 Inactive
@sonarcloud
Copy link

sonarcloud bot commented Mar 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@camdenmoors camdenmoors merged commit 5d6ac94 into master Mar 18, 2022
@camdenmoors camdenmoors deleted the splunkUpdates branch March 18, 2022 17:22
@camdenmoors camdenmoors restored the splunkUpdates branch March 24, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amndeep7 Amndeep7 Amndeep7 left review comments

@aaronlippold aaronlippold aaronlippold left review comments

@georgedias georgedias georgedias requested changes

@ejaronne ejaronne Awaiting requested review from ejaronne

Assignees

@Amndeep7 Amndeep7

@em-c-rod em-c-rod

@camdenmoors camdenmoors

Labels
bug Something isn't working enhancement New feature or request ready-to-merge Used by mergify to identify if a PR is ready to merge into master.
Projects
None yet
Milestone
No milestone
5 participants
@camdenmoors @Amndeep7 @aaronlippold @georgedias @em-c-rod