Initial work on performance #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there are just some unused-related warnings, plus Conventional Commits issues, and then it's ready to merge. Probably just squash down to one commit and reword the message to match Conventional Commits. |
…and replacing `filter_map` with `filter` and `map` in two places.
|
@alilleybrinker assuming this last check is successful (it should be) I think this is ready to review/merge! |
alilleybrinker
approved these changes
Jun 19, 2024
j-lanson
reviewed
Jun 19, 2024
Comment on lines
+399
to
+401
| // If no subcommand matched, default to use of '-t <TYPE> <TARGET' syntax. In | ||
| // this case, `target` is a required field, but the existence of a subcommand | ||
| // removes that requirement |
There was a problem hiding this comment.
If this comment was intentionally duplicated, is there a good reason for doing so?
There was a problem hiding this comment.
This was unintentional! Probably happened while merging. Thanks for catching this!
| use tempdir::TempDir; | ||
|
|
||
| /// Handle unstable commands. | ||
| pub fn main(args: UnstableArgs, config: &CliConfig) -> io::Result<()> { |
There was a problem hiding this comment.
I would stylistically opt for a different name, such as run or run_unstable, but not a big deal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several commits, but the most major change is that
Rchas been replaced withArcthroughout much of the repository, in order to prepare for improvements from multithreading.