Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove pr analysis and scoring infrastructure #158

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

j-lanson
Copy link
Collaborator

While working on the scoring infrastructure refactor, I encountered the fact that PR analyses have their own PrConcern type separate from Concern used by repo analyses. In discussing with @alilleybrinker he advised to remove the PR analysis infrastructure entirely. This PR demonstrates what that would look like.

@j-lanson j-lanson requested a review from alilleybrinker June 27, 2024 14:56
@j-lanson j-lanson added the type: chore Clean up or management task. label Jun 27, 2024
alilleybrinker
alilleybrinker previously approved these changes Jun 27, 2024
Copy link
Collaborator

@alilleybrinker alilleybrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nice thing is of course that Git retains all of this so if for some reason we wanted to add this back in the future, we could.

@alilleybrinker alilleybrinker merged commit 5f9611a into main Jun 27, 2024
9 checks passed
@j-lanson j-lanson deleted the jlanson/remove-pr-scoring branch July 31, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Clean up or management task.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants