Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds hc update command #176

Merged
merged 1 commit into from
Jul 3, 2024
Merged

feat: Adds hc update command #176

merged 1 commit into from
Jul 3, 2024

Conversation

mchernicoff
Copy link
Contributor

@mchernicoff mchernicoff commented Jul 3, 2024

Resolves issue #56 Adds hc update command to run the self-updater (if installed). This updater comes with the current Hipcheck installer as created by cargo-dist using the axoupdater crate. The hc-update command simply calls the axoupdater provided updater, but integrated into the regular Hipcheck CLI.

This command automatically brings Hipcheck up to date with the latest released version if run without any flags. The user can includes optional flags to update to versions other than the latest.

N.B. Because of a bug in cargo-dist, we cannot be sure if the axoupdater updater will be installed as hc-update or hipcheck-update. Therefore the new hc update command tries both commands. If this bug is resolved in the future, we can remove the step of checking both possible commands.

Also updates the version of cargo-dist to 0.17.0.

@mchernicoff mchernicoff added the type: enhancement New feature or request label Jul 3, 2024
@mchernicoff mchernicoff added this to the 3.4.0 milestone Jul 3, 2024
@mchernicoff mchernicoff self-assigned this Jul 3, 2024
@mchernicoff mchernicoff linked an issue Jul 3, 2024 that may be closed by this pull request
@mchernicoff mchernicoff force-pushed the mchernicoff/updater branch from e9b0c79 to d21015d Compare July 3, 2024 14:33
hipcheck/src/main.rs Outdated Show resolved Hide resolved
@alilleybrinker
Copy link
Collaborator

@mchernicoff it looks like a newline was mistakenly added to the bottom of the cargo-dist GitHub Action file, which is causing a CI error.

@mchernicoff
Copy link
Contributor Author

mchernicoff commented Jul 3, 2024

@mchernicoff it looks like a newline was mistakenly added to the bottom of the cargo-dist GitHub Action file, which is causing a CI error.

Saw that. Fixing it in next commit.

…o automatically bring Hipcheck up to date with a released version. Includes optional flags to update to versions other than the latest.
@mchernicoff mchernicoff force-pushed the mchernicoff/updater branch from d21015d to 2fb15f1 Compare July 3, 2024 17:15
@alilleybrinker alilleybrinker merged commit cd9b7db into main Jul 3, 2024
9 checks passed
@mchernicoff mchernicoff deleted the mchernicoff/updater branch July 3, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Incorporate self-updating with new hc update command.
2 participants