chore: Create docker image SBOM on release #269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alilleybrinker
previously approved these changes
Aug 9, 2024
|
@mchernicoff looks like this has a merge conflict with the changes @patrickjcasey made for checking Docker README size. Can you rebase? |
mchernicoff
force-pushed
the
mchernicoff/docker-sbom
branch
2 times, most recently
from
246f566 to
0f163bc
Compare
mchernicoff
force-pushed
the
mchernicoff/docker-sbom
branch
from
0f163bc to
cd9648b
Compare
alilleybrinker
changed the title
alilleybrinker
changed the title
|
Going to close this. I'm in the process of some more substantial reworking of how releases work, and while I definitely want SBOM building to be a part of that, I don't think it'll necessarily take this form. I'll be sure to refer back to this though, and @mchernicoff I appreciate the work you did on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves first part of Issue #171 (other parts are waiting on changes to
cargo-dist). Adds a GitHub action to create an SPDX SBOM for the Hipcheck docker image after we create and push that image during the normal release workflow. The SBOM should be automatically added as an artifact to the same release.Draft because this has not been tested yet. We need to come up with a good way to test this that does not involve creating many unnecessary docker images.