-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Simplify Release Procedures RFD #430
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alilleybrinker
added
type: chore
Clean up or management task.
product: release-flow
labels
Sep 19, 2024
j-lanson
reviewed
Sep 23, 2024
j-lanson
reviewed
Sep 23, 2024
alilleybrinker
force-pushed
the
alilleybrinker/release-rfd
branch
from
September 23, 2024 15:22
962b302
to
d79972e
Compare
j-lanson
previously approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes a lot of sense, and the trade-off seems very worthwhile.
This RFD recommends changes to simplify the release processes for Hipcheck, explaining the problems with the current setup, and the benefits of the proposed changes. Signed-off-by: Andrew Lilley Brinker <[email protected]>
alilleybrinker
force-pushed
the
alilleybrinker/release-rfd
branch
from
September 23, 2024 15:32
d79972e
to
e50d297
Compare
My apologies, I realized my force-push actually hadn't include the changes because I forgot a |
@j-lanson can I get a re-review? |
j-lanson
approved these changes
Sep 23, 2024
alilleybrinker
added
product: project
Relates to the project itself
and removed
product: release-flow
labels
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This RFD recommends changes to simplify the release processes for Hipcheck, explaining the problems with the current setup, and the benefits of the proposed changes.