Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Simplify Release Procedures RFD #430

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

alilleybrinker
Copy link
Collaborator

This RFD recommends changes to simplify the release processes for Hipcheck, explaining the problems with the current setup, and the benefits of the proposed changes.

@alilleybrinker alilleybrinker added type: chore Clean up or management task. product: release-flow labels Sep 19, 2024
@alilleybrinker alilleybrinker added this to the 3.7.0 milestone Sep 19, 2024
@alilleybrinker alilleybrinker self-assigned this Sep 19, 2024
@alilleybrinker alilleybrinker force-pushed the alilleybrinker/release-rfd branch from 962b302 to d79972e Compare September 23, 2024 15:22
j-lanson
j-lanson previously approved these changes Sep 23, 2024
Copy link
Collaborator

@j-lanson j-lanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes a lot of sense, and the trade-off seems very worthwhile.

This RFD recommends changes to simplify the release processes for Hipcheck,
explaining the problems with the current setup, and the benefits of the
proposed changes.

Signed-off-by: Andrew Lilley Brinker <[email protected]>
@alilleybrinker
Copy link
Collaborator Author

My apologies, I realized my force-push actually hadn't include the changes because I forgot a git add 🤦🏻

@alilleybrinker
Copy link
Collaborator Author

@j-lanson can I get a re-review?

@j-lanson j-lanson merged commit 37f5a16 into main Sep 23, 2024
7 checks passed
@alilleybrinker alilleybrinker deleted the alilleybrinker/release-rfd branch September 24, 2024 16:31
@alilleybrinker alilleybrinker added product: project Relates to the project itself and removed product: release-flow labels Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: project Relates to the project itself type: chore Clean up or management task.
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants