Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Pull attestation from include-attestations-file #12

Merged
merged 10 commits into from
Apr 13, 2021
Merged

Conversation

rx294
Copy link
Collaborator

@rx294 rx294 commented Apr 6, 2021

Fixes #9 Ignores attestation upon status being nil or "".
Fixes #10 Accepts attestation from template csv or xlsx
Fixes #14 Attestation will mod existing statuses, just append attestation based block to results array

Signed-off-by: Rony Xavier [email protected]

@ejaronne
Copy link
Contributor

ejaronne commented Apr 9, 2021

  • Might it be possible to put the attestation as the first subtest result, not the last? Easier to spot that way.
  • Please simplify "Manually verified Status provided through attestation" to just "Status provided through attestation"

@rx294
Copy link
Collaborator Author

rx294 commented Apr 13, 2021

Merging to master after @ejaronne tested the gem.

@rx294 rx294 merged commit d93cbde into main Apr 13, 2021
@rx294 rx294 deleted the csv_attestation branch April 13, 2021 15:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants