Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed browser-api/common/Makefile (avoid the dependency error when directories creating) #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed browser-api/common/Makefile (avoid the dependency error when directories creating) #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions browser-ext/login/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,30 +296,30 @@ $(1):
endef

define COPY_RULE
$(2): $(1) | $(dir $(2))
$(2): $(1) | $(patsubst %/,%,$(dir $(2)))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is patsubst greedy? this won't convert foo/bar/whatever into foobarwhatever will it?

@echo $(2)
@cp $(1) $(2)
endef

define EXTRACT_SCRIPTS_RULE
$(2): $(1) | $(dir $(2))
$(2): $(1) | $(patsubst %/,%,$(dir $(2)))
@$(SCRIPTS_EXTRACTOR) extract $(1) $(2)
endef

define CLOSURE_COMPILER_RULE
$(2): $(1) | $(dir $(2))
$(2): $(1) | $(patsubst %/,%,$(dir $(2)))
@echo $(2)
@$(CLOSURE) --js $(1) --js_output_file $(2) || exit $$?
endef

define MUSTACHE_RENDERER_RULE
$(2): $(1) $(dir $(2)) $(BASE_TEMPLATE_FILES)
$(2): $(1) $(patsubst %/,%,$(dir $(2))) $(BASE_TEMPLATE_FILES)
@echo $(2)
@NODE_PATH=../third_party node $(MUSTACHE_RENDERER) $(1) $(abspath $(2))
endef

define MUSTACHE_COMPILER_RULE
$(2): $(1) $(dir $(2))
$(2): $(1) $(patsubst %/,%,$(dir $(2)))
@echo $(2)
@$(MUSTACHE_COMPILER) $(1) > $(abspath $(2))
endef
Expand Down