Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh refactor #63

Merged
merged 8 commits into from
Dec 14, 2023
Merged

Mesh refactor #63

merged 8 commits into from
Dec 14, 2023

Conversation

bathal1
Copy link
Collaborator

@bathal1 bathal1 commented Jun 8, 2023

Description

This PR addresses compatibility issues caused by data layout changes in Blender's mesh representation for the exporter add-on. With these changes, the exporter should now support versions 3.4 and 3.5 of Blender, which should make it easier to support the upcoming LTS version.

The mesh layout in blender is progressively moving from an array of structs to a struct of arrays format (more detail here, so we need to reflect those changes when interpreting blender data pointers in the mesh exporter.

This PR fixes #58 . In order for these changes to be fully reflected in the exporter, we would need to have a new release of the Mitsuba PyPI package and update the dependency in the addon.

@jmoraispk
Copy link

Hey @bathal1
Any update here?
Mitstuba in blender 3.6 would be fantastic! :)

@bathal1
Copy link
Collaborator Author

bathal1 commented Aug 17, 2023

This PR will be merged once the corresponding changes to Mitsuba will be included in the upcoming release.

@jmoraispk
Copy link

Thanks 🙏
Could you tell me if there is any arranged timeline for that? Or are there any dependent issues still getting closed?

@bathal1
Copy link
Collaborator Author

bathal1 commented Aug 22, 2023

Hi,
the next release of Mitsuba 3 should come out in the next weeks, but I can't give you a precise date.

If you really need the add-on to work in Blender 3.6 or downgrading Blender is not a viable option, you could try to use the addon from source. Note that this will require building Mitsuba 3 from source as well, and it's known to be brittle in some cases.

@arpit15
Copy link

arpit15 commented Sep 13, 2023

@bathal1 Since the new mitsuba is released, I am wondering if there is a timeline for merging this? I am happy to take this initiative if you can't allocate time to this.

@arpit15
Copy link

arpit15 commented Sep 17, 2023

I tested this branch with mitsuba 3.4.0. @bathal1 It seems to export correct mesh. Is there any other work required for merging this? Is there any other planned work for a new release?

@bathal1 bathal1 merged commit bb4b7b6 into master Dec 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporter: Incorrect PLY geometries when exporting (Blender 3.4+)
4 participants