-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optix 8 abi bump #1480
Optix 8 abi bump #1480
Conversation
Hi @njroussel, Does this API bump change the minimum supported driver version? (Just to make sure that it is documented and checked at runtime). |
There is an error message in Dr.Jit-Core when OptiX is first used. But the Mitsuba documentation likely needs an update. |
This looks great. For posterity, can you explain the simplification?
|
I can't even tell what I originally wanted to write, that's just a typo mess. This is the relevant commit: 3a6aa70
I didn't think to check the Mitsuba docs, there were a few places that mentioned the required driver version. I pushed a commit to update those. |
The previous code would submit them all even if the pipeline only used a subset of them. In theory, that should not matter. However, OptiX 8.0 flags that as a potential issue when the validation layer is enabled.
This commit also update the `resources/data` submodule which holds the references for the OptiX denoiser tests
d6550d3
to
993fd8b
Compare
Description
This PR is part of a series to upgrade to OptiX 8.0:
It introduces the following changes:
OptixDenoiser
interfaceresources/data
submodule must be updated prior to merging this PR.Testing
No new tests were added. Tests for
OptixDenoiser
were updated due to the new interface.