Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "app update" command to modify entrypoint/documentroot/... #520

Merged
merged 17 commits into from
Aug 29, 2024

Conversation

martin-helmich
Copy link
Member

  • Add "app update" command to change entrypoint+docroot
  • Update README

@martin-helmich martin-helmich marked this pull request as draft August 22, 2024 11:44
@martin-helmich martin-helmich marked this pull request as ready for review August 22, 2024 11:44
@niristius
Copy link
Contributor

some testing was done although due rather current versions of everything in the studio, the amount of dependencies that need to be upgraded are very limited. I could only force PHP version to be low enough to require an upgrade during the app upgrade process.

@niristius
Copy link
Contributor

niristius commented Aug 27, 2024

For clarification - I just realized this.
I kinda hijacked this branch.
@martin-helmich initially created this branch and added the app update command to change configurations of an app, entrypoints to be precise.
What I added is the app upgrade command to trigger version upgrades for apps.
This is ready to be merged.

src/commands/app/upgrade.tsx Outdated Show resolved Hide resolved
src/commands/app/upgrade.tsx Outdated Show resolved Hide resolved
src/commands/app/upgrade.tsx Show resolved Hide resolved
@niristius
Copy link
Contributor

@martin-helmich I cant request a review from you since I hijacked this branch from you. So here's my written request 😄

@martin-helmich martin-helmich merged commit 16b5584 into master Aug 29, 2024
8 checks passed
@martin-helmich martin-helmich deleted the feature/app-update branch August 29, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants