Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preload talks and users #5

Merged
merged 3 commits into from
Apr 15, 2018
Merged

Preload talks and users #5

merged 3 commits into from
Apr 15, 2018

Conversation

gzoritchak
Copy link
Contributor

@gzoritchak gzoritchak commented Apr 12, 2018 •
edited
Loading

Touch the TalkReader and UserReader instance at the end of the app creation to read the json files and keep the users and talks in memory.

The call is done using coroutines.

     launch {
            TalkReader.getInstance(baseContext)
            UserReader.getInstance(baseContext)
        }

It's an enhancement for issue #4

@gzoritchak gzoritchak changed the title Preload talks and users Preload talks and users #4 Apr 12, 2018
@gzoritchak gzoritchak changed the title Preload talks and users #4 Preload talks and users Apr 12, 2018
javamind
javamind approved these changes Apr 15, 2018
View reviewed changes
Copy link
Member

@javamind javamind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javamind javamind merged commit 8e8c838 into mixitconf:master Apr 15, 2018
@gzoritchak gzoritchak deleted the preload branch April 15, 2018 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javamind javamind javamind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gzoritchak @javamind