Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove bash prompt in install code #76

Closed

Conversation

vnsam
Copy link

@vnsam vnsam commented Feb 21, 2022

Copying the installation code also includes the $ sign.

Now the user has to click on the copy clipboard;
Remove the dollar sign manually;
And paste it into the terminal.

Removing this $ sign in the install code snippet eliminate one movement.

@vnsam
Copy link
Author

vnsam commented Feb 21, 2022

@mixn

@mixn
Copy link
Owner

mixn commented Feb 6, 2023

Sorry I never took a look at this. Slowly coming back to this side project. 🙂 I’ve started work on #83 and will look at this PR before I move too far away from the current state of the code base. I’ll either merge or close this soon, just fyi. Closing will happen if I decide to approach the issue differently as part of the v2 update.

Thank you again for your time!

@mixn
Copy link
Owner

mixn commented May 12, 2023

@vnsam I’m finalizing the huge v2 release and since literally everything is new ™ I happened to just remove the $ myself since I had to go over the docs for v2 anyway.

I don’t want to be taking away from you as a contributor, though, so pls let me know how you wanna proceed. If you’re fine with just closing this PR, that’s okay with me, but I can also re-add all the $, and you can submit a new PR once the v2 branch is merged into master, removing them all in bulk.

carbon-now-cli isn’t using all-contributors/cli (yet), otherwise, you could have just added yourself there, even if we closed the PR.

Happy to hear your thoughts. :)

@mixn mixn closed this May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants