Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower js constraint to allow 0.6.x #142

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

thedalelakes
Copy link
Contributor

Because google_maps_flutter >=2.6.0 depends on google_maps_flutter_web ^0.5.6 which depends on google_maps ^7.1.0, google_maps_flutter
  >=2.6.0 requires google_maps ^7.1.0.
And because google_maps >=6.3.0 depends on js ^0.6.3 and mixpanel_flutter >=2.3.0 depends on js ^0.7.1, google_maps_flutter >=2.6.0 is
  incompatible with mixpanel_flutter >=2.3.0.
So, because <app_name> depends on both google_maps_flutter ^2.6.0 and mixpanel_flutter ^2.3.0, version solving failed.

I'm on the latest version of both google_maps_flutter and mixpanel_flutter. Upgrading the js dep to only ^0.7.x broke compatibility with google_maps_flutter, and I'm sure other plugins were affected as well.

This PR lowers the constraint to allow 0.6.x.

@zihejia
Copy link
Collaborator

zihejia commented May 9, 2024

Thanks @thedalelakes @cerberodev !

@zihejia zihejia merged commit e586c66 into mixpanel:main May 9, 2024
3 checks passed
@chadpav
Copy link

chadpav commented Jul 29, 2024

I have this conflict with a couple of packages as well. Can you cut a release with this change in it? It's merged into main but that came after the 2.3.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants