Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: teddddd <[email protected]>
  • Loading branch information
iatsiuk and tdumitrescu authored Sep 10, 2023
1 parent 600d6ab commit 8b7f570
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions test/logger.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@ exports.logger = {
next();
},

"is default logger is console object": function(test) {
"defaults to console logger": function(test) {
const loggerName = Object.prototype.toString.call(this.mixpanel.config.logger);
test.deepEqual(loggerName, '[object console]', "default logger is incorrect");
test.done();
},

"is throws an error on incorrect logger object": function(test) {
"throws an error on incorrect logger object": function(test) {
test.throws(
() => this.mixpanel.set_config({logger: false}),
TypeError,
Expand All @@ -38,7 +38,7 @@ exports.logger = {
test.done();
},

"is write log for track() method": function(test) {
"writes log for track() method": function(test) {
this.mixpanel.set_config({debug: true});

this.mixpanel.track('test', {foo: 'bar'});
Expand All @@ -58,7 +58,7 @@ exports.logger = {
test.done();
},

"is write log for increment() method": function(test) {
"writes log for increment() method": function(test) {
this.mixpanel.set_config({debug: true});

this.mixpanel.people.increment('bob', 'page_views', 1);
Expand All @@ -78,7 +78,7 @@ exports.logger = {
test.done();
},

"is write log for remove() method": function(test) {
"writes log for remove() method": function(test) {
this.mixpanel.set_config({debug: true});

this.mixpanel.people.remove('bob', {'browsers': 'firefox'});
Expand Down

0 comments on commit 8b7f570

Please sign in to comment.