Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safer handling of super properties #197

Merged
merged 1 commit into from
Jun 16, 2023
Merged

safer handling of super properties #197

merged 1 commit into from
Jun 16, 2023

Conversation

zihejia
Copy link
Contributor

@zihejia zihejia commented Jun 13, 2023

address #179

@zihejia zihejia force-pushed the fix-hermes-crash branch from 3c23bc2 to 5ebcc04 Compare June 13, 2023 07:11
@zihejia zihejia added the bug Something isn't working label Jun 13, 2023
@zihejia zihejia requested a review from jaredmixpanel June 13, 2023 22:35
@matthewmturner
Copy link

@zihejia @jaredmixpanel thanks for this. any idea when the fix will be released?

@matthewmturner
Copy link

@zihejia @jaredmixpanel anything on this? we were actually in the middle of removing mixpanel from our app because of this issue. but im ok to put that work on pause and see if the fix you have here works. any information you could share on this would be greatly appreciated.

@zihejia
Copy link
Contributor Author

zihejia commented Jun 16, 2023

hi @matthewmturner , I will release it by tomorrow.

@matthewmturner
Copy link

@zihejia Thank you. For my information can you provide color on what the issue was?

@zihejia zihejia merged commit 431c556 into master Jun 16, 2023
@zihejia
Copy link
Contributor Author

zihejia commented Jun 17, 2023

hi @matthewmturner , this might relate to the race conditions that mutate the properties during the initialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants