safer handling of super properties #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zihejia
force-pushed
the
fix-hermes-crash
branch
from
3c23bc2 to
5ebcc04
Compare
jaredmixpanel
approved these changes
Jun 14, 2023
|
@zihejia @jaredmixpanel thanks for this. any idea when the fix will be released? |
|
@zihejia @jaredmixpanel anything on this? we were actually in the middle of removing mixpanel from our app because of this issue. but im ok to put that work on pause and see if the fix you have here works. any information you could share on this would be greatly appreciated. |
|
hi @matthewmturner , I will release it by tomorrow. |
|
@zihejia Thank you. For my information can you provide color on what the issue was? |
|
hi @matthewmturner , this might relate to the race conditions that mutate the properties during the initialization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #179