Potential fix for code scanning alert no. 4: Incomplete URL substring sanitization #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/mixtapejaxson/ChatTweak/security/code-scanning/4
To fix the problem, the URL must be parsed and the relevant components—typically origin, host, or path—checked explicitly.
urlString.includes(SPOTLIGHT_URL), parse the URL and compare itsoriginandpathnameto the intended Spotlight endpoint.https://web.snapchat.comand the path starts with/context/spotlight(or equals, depending on desired strictness).URLWeb API to parseurlString. This is available in all modern browsers and in Node, so it does not require any extra packages.URLis global, but wrap parsing in a try/catch to ensure malformed URLs don’t cause crashes.Only lines within
src/script/modules/telemetry-blocker/index.tsneed changes, specifically the conditional on line 106. Show several lines of context on each side, and add new code only as required by the fix.Suggested fixes powered by Copilot Autofix. Review carefully before merging.