Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use WINDOWS_EXPORT_ALL_SYMBOLS instead of __declspec(dllexport) #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

use WINDOWS_EXPORT_ALL_SYMBOLS instead of __declspec(dllexport) #6

wants to merge 1 commit into from

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Jan 15, 2021

No description provided.

@Be-ing Be-ing force-pushed the WINDOWS_EXPORT_ALL_SYMBOLS branch 2 times, most recently from 4940c2e to 6e4058c Compare January 15, 2021 01:27
@Holzhaus
Copy link
Member

But hss1394 should only export those in the include/ headers, not the other ones, right?

@Be-ing
Copy link
Contributor Author

Be-ing commented Jan 15, 2021 •
edited
Loading

Who cares? Apparently nobody who uses dynamically linked libraries built with any compiler besides MSVC.

@Be-ing
Copy link
Contributor Author

Be-ing commented Jan 15, 2021

Only symbols from installed headers can be used anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Be-ing @Holzhaus