This adjustment guarantees delay_frames will always be positive, preventing the assertion from triggering when the track is not playing. #13805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enting the assertion from triggering when the track is not playing.
|
This would only eliminate the symptom, but does not fix the cause. To eliminate the cause, you must first get an understanding of why these values occur. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
EchoEffect::processChannel()function, when the track is not playing, a default value fordelay_framesshould be set to ensure it is greater than zero and to avoid assertion failure. You can setdelay_framesto a minimal positive value like1to handle the case when the track is not playing.This ensures that
delay_framesis always set to a positive value, avoiding the assertion failure.Hope this will work...
Issue #13799