fix: Avoid appending redundant def object

miyanokomiya · Feb 10, 2024 · 7ff8d90 · 7ff8d90
1 parent d4ffc7d
commit 7ff8d90
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/composables/shapeSVGRenderer.ts b/src/composables/shapeSVGRenderer.ts
@@ -52,7 +52,6 @@ export function newShapeSVGRenderer(option: Option) {
     // Embed asset files used in this SVG.
     const usedAssetIdSet = new Set();
     const assetDef = createSVGElement("def");
-    root.appendChild(assetDef);
     root.querySelectorAll("use[href]").forEach((elm) => {
       const assetId = (elm as SVGUseElement).href.baseVal.slice(1);
       if (usedAssetIdSet.has(assetId)) return;
@@ -77,6 +76,9 @@ export function newShapeSVGRenderer(option: Option) {
       });
       assetDef.appendChild(imageElm);
     });
+    if (assetDef.children.length > 0) {
+      root.prepend(assetDef);
+    }
 
     return root;
   }