fix: Avoid including shapes with "cropClipBorder" on for getting wrap…

…per rectangle

- They won't consist the bounds of the group.

src/shapes/core.spec.ts

@@ -1,5 +1,6 @@
 import { expect, describe, test } from "vitest";
 import {
+  canHaveOutlineWithinGroup,
   getCommonStyle,
   hasStrokeStyle,
   isInvisibleClippingShape,
@@ -109,3 +110,32 @@ describe("isInvisibleClippingShape", () => {
     ).toBe(true);
   });
 });
+
+describe("canHaveOutlineWithinGroup", () => {
+  test("should return true when a shape can outline of its parent group", () => {
+    const rect = createShape<RectangleShape>(getCommonStruct, "rectangle", {});
+    expect(canHaveOutlineWithinGroup({ ...rect, clipping: false })).toBe(true);
+    expect(
+      canHaveOutlineWithinGroup({
+        ...rect,
+        clipping: true,
+        stroke: createStrokeStyle({ disabled: true }),
+      } as RectangleShape),
+    ).toBe(false);
+    expect(
+      canHaveOutlineWithinGroup({
+        ...rect,
+        clipping: true,
+        stroke: createStrokeStyle({ disabled: false }),
+      } as RectangleShape),
+    ).toBe(true);
+    expect(
+      canHaveOutlineWithinGroup({
+        ...rect,
+        clipping: true,
+        cropClipBorder: true,
+        stroke: createStrokeStyle({ disabled: false }),
+      } as RectangleShape),
+    ).toBe(false);
+  });
+});

src/shapes/core.ts

@@ -184,3 +184,9 @@ export function hasStrokeStyle(shape: Shape): shape is Shape & { stroke: StrokeS
 export function isInvisibleClippingShape(shape: Shape): boolean {
   return !!shape.clipping && (!hasStrokeStyle(shape) || !!shape.stroke.disabled);
 }
+
+export function canHaveOutlineWithinGroup(shape: Shape): boolean {
+  if (!shape.clipping) return true;
+  if (shape.cropClipBorder) return false;
+  return hasStrokeStyle(shape) && !shape.stroke.disabled;
+}

src/shapes/group.ts

@@ -1,4 +1,4 @@
-import { ShapeContext, ShapeStruct, createBaseShape, isInvisibleClippingShape } from "./core";
+import { ShapeContext, ShapeStruct, canHaveOutlineWithinGroup, createBaseShape } from "./core";
 import { ClipRule, Shape } from "../models";
 import { getRectPoints, getRotateFn, getWrapperRect } from "../utils/geometry";
 import { IVec2, applyAffine, getOuterRectangle, getRadian, getRectCenter } from "okageo";
@@ -38,7 +38,7 @@ export const struct: ShapeStruct<GroupShape> = {
     let targetList = children;
     if (includeBounds) {
       // Omit invisible clipping shapes when they work.
-      const [icList, others] = splitList(children, (s) => isInvisibleClippingShape(shapeContext.shapeMap[s.id]));
+      const [others, icList] = splitList(children, (s) => canHaveOutlineWithinGroup(shapeContext.shapeMap[s.id]));
       targetList = icList.length > 0 && others.length > 0 ? others : children;
     }