Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/clip #14

Merged
merged 21 commits into from
Sep 22, 2024
Merged

Feat/clip #14

merged 21 commits into from
Sep 22, 2024

Conversation

miyanokomiya
Copy link
Owner

shapes folly

@miyanokomiya
feat: Introduce shape clipping
200aedc 
- Let group shapes have clip-rule.
@miyanokomiya
feat: Take care of clipPath on SVG export
a657f05 
- Group shapes need to make `<g>` element to apply clipping
@miyanokomiya
refactor: Polish method names
60f3b17
@miyanokomiya
fix: Invalid clipping path for rectangles
bc22f1d
@miyanokomiya
feat: Add some fields for clipping to the inspector panel
7e34bbd
@miyanokomiya
feat: Introduce clip modes: in / out
c1aa81b 
- These modes are much more intuitive and convenient than primitive nonzero / evenodd.
-- Out mode is also unfeasible just by using primitive nonzero / evenodd.
@miyanokomiya
fix: Treat clip "out" as default mode
4ced85c 
- Clip "in" won't be used much while diagramming.
@miyanokomiya
feat: Implement clipping methods of shapes
eacdf6a
@miyanokomiya
refactor: Omit needless converting
4aa0c57
@miyanokomiya
test: Add test
e48bfef
@miyanokomiya
feat: Render outline of clipping shapes
8855755
@miyanokomiya
fix: Reserve inner arc path of a donut
3914687
@miyanokomiya
fix: Make wrapper rectangle big enough to accommodate the boundary
d8bc711 
- Making it beggier doesn't matter at all to snapping.
@miyanokomiya
feat: Clip clipping outline out
6d7fc01
@miyanokomiya
refactor: Polish components for clip functionality
d397e2c
@miyanokomiya
feat: Add new property to determine if outside border should be cropped
478ce16 
- The property of the top most cripping shape overrides all nested shapes.
@miyanokomiya
fix: Treat "undefined" of "clipRule" as "out"
9ab784a 
- It's the default value.
@miyanokomiya
fix: Regard tree structure of shapes on exporting
7bf4a25
@miyanokomiya
fix: Set "includeBounds" flag true
953c1bb
@miyanokomiya
feat: Avoid including invisible clipping shapes to calculate wrapper …
0835ebe 
…renctagle with bounds

- They don't have meaning appearance alone
@miyanokomiya
fix: Remove obsolete line
b113622
@miyanokomiya miyanokomiya added the enhancement New feature or request label Sep 22, 2024
@miyanokomiya miyanokomiya merged commit 2d1d5f4 into main Sep 22, 2024
2 checks passed
@miyanokomiya miyanokomiya deleted the feat/clip branch September 22, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@miyanokomiya