Skip to content

Commit

Permalink
Restrict net-ssh version for CI builds with Ruby < 2.0.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@mizzy
mizzy committed Dec 13, 2015
1 parent 99bc7e8 commit 35989d7
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions Gemfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ source 'https://rubygems.org'
# Specify your gem's dependencies in serverspec.gemspec
gemspec

# Put Gemfile.local to use arbitrary gems for your use case.
path = Pathname.new("Gemfile.local")
eval(path.read) if path.exist?
if Gem::Version.new(RUBY_VERSION.dup) < Gem::Version.new('2.0.0')
# net-ssh 3.x dropped Ruby 1.8 and 1.9 support.
gem 'net-ssh', '~> 2.7'
end

2 comments on commit 35989d7

@gwynforthewyn
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mizzy I just noticed this commit as potentially being a breaking change in the test-kitchen busser gem. If you have a minute and could check the bug report at test-kitchen/busser#32 it'd be neat to know whether I filed the bug in the right place.

@biinari
Copy link

@biinari biinari commented on 35989d7 Jan 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamandbees, the Gemfile here won't be used by busser, it will only look to the gemspec. I think it is best fixed in the specinfra gemspec like so: mizzy/specinfra#513

Please sign in to comment.