Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump and set min version of holidays to 0.59 to include 2025-05-08 ("Tag der Befreiung") #181

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

hf-kklein
Copy link
Contributor

…efreiung")

it's not released yet but will include a fix for vacanza/holidays#2051

will be released on Oct 21st vacanza/holidays#2052 (comment)

…efreiung")

it's not released yet but will include a fix for vacanza/holidays#2051

will be released on Oct 21st vacanza/holidays#2052 (comment)
@hf-kklein hf-kklein changed the title Set min version of holidays to 0.59 to include 2025-05-08 ("Tag der B… Set min version of holidays to 0.59 to include 2025-05-08 ("Tag der Befreiung") Oct 17, 2024
@hf-kklein
Copy link
Contributor Author

noch nicht mergen, aber sobald dependabot vorbeikam und den version bump gemacht hat.

@PPsyrius
Copy link

PPsyrius commented Oct 18, 2024

@hf-kklein you might want to bump the minimum Python version to 3.9 as well as future holidays 0.59 release drops 3.8 support due to its EOL status.

pyproject.toml Outdated Show resolved Hide resolved
as suggested in mj0nez#181 (comment)

but why do we set this here at all? doesn't holidays itself define its minimal required python version?
tbh I changed it manually
@hf-kklein hf-kklein marked this pull request as ready for review October 28, 2024 05:54
@hf-kklein hf-kklein changed the title Set min version of holidays to 0.59 to include 2025-05-08 ("Tag der Befreiung") Bump and set min version of holidays to 0.59 to include 2025-05-08 ("Tag der Befreiung") Oct 28, 2024
@mj0nez mj0nez merged commit 3ccb287 into mj0nez:main Oct 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants