Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-ordered env merge to ensure provider.environment takes precedence … #176

Merged
merged 2 commits into from
Oct 29, 2023
Merged

Re-ordered env merge to ensure provider.environment takes precedence … #176

merged 2 commits into from
Oct 29, 2023

Conversation

MajorCaiger
Copy link
Contributor

…over the host env

serverless-offline merges in the following order:

  • process.env
  • provider.env
  • function.env

before this change, serverless-offline-sns was merging in this order:

  • provider.env
  • process.env
  • function.env

@MajorCaiger MajorCaiger mentioned this pull request Apr 3, 2023
Closed
@dsarlo dsarlo self-requested a review October 29, 2023 18:56
@dsarlo dsarlo merged commit d51e1b8 into mj1618:main Oct 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsarlo dsarlo dsarlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MajorCaiger @dsarlo