Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to create JPG images from PDF page #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

homestar9
Copy link

No description provided.

Copy link
Owner

@mjclemente mjclemente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this! And I'm sorry it's taken me so long to get around to reviewing it.

The method itself is great, and exposing the renderImage functionality seems useful.

My only concern is that, as it is, it's doing a little much, and I'd like to keep the project focused on the PDFBox functionality.

My first impression is that the functionality related to resizing and cfimage could be removed. If/how the resulting image is resized seems like more of an application level decision.

Happy to hear your thoughts if you think otherwise - and if you don't want to make the changes, I can merge this and then make them myself - not trying to make more work for you.

Again thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants