Added file extension for nvram files when ROM filename is provided #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added file extension for nvram files when ROM filename is known
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting high scores for Visual Pinball/VPinMAME doesn't work that well. Multiple ROM names mean nothing is chosen. One way to resolve this is to explicitly provide the ROM name in the table setup. However the ".nv" file extension is not added by the code and so the NMRAM file with the scores is still not found.
This code was tested with the TOTAN ROM that has at least two ROM files (totan_12.zip and totan_14.zip).