Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update protobuf #1013

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Update protobuf #1013

wants to merge 31 commits into from

Conversation

sotetsuk
Copy link
Collaborator

@sotetsuk sotetsuk commented Oct 28, 2021 •
edited
Loading

気になっている点

  • Agent.TakeAction
  • ACTION_TYPE_NO
  • draw_history
  • NoWinner 実際、三家和了のときはNoWnnerといっていいのかよくわからない。Drawとしても混乱はなさそうか。
  • game_id in Action
  • Event と Action の要素の並び順が違う
  • roundという単語はよくないかもしれない（東場、南場の意味で使われる）
  • who => player_idx (?)

sotetsuk and others added 30 commits October 28, 2021 17:01
@sotetsuk sotetsuk mentioned this pull request Oct 28, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sotetsuk