Incorporate Zeusd for CPU and DRAM monitoring in ZeusMonitor #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michahn01 Thanks for your work! CI is failing; please look into the CI logs and get them to pass. You can also check the exact command being run for each workflow file in |
Got it! The issues were fixed, I believe CI should pass now. |
jaywonchung
reviewed
Jan 28, 2025
There was a problem hiding this comment.
Thanks for your work! You nailed most parts on your first contribution, too! I think it's good to go after some minor changes.
@wbjin Could you take a look at this PR as well?
jaywonchung
reviewed
Jan 28, 2025
michahn01
force-pushed
the
Incorporate_Zeusd_for_CPU_and_DRAM_Monitoring_in_ZeusMonitor
branch
from
c2886de to
4cbe58f
Compare
jaywonchung
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses this issue: #146
Overview of changes:
ZeusdRAPLCPUtozeus/device/cpu/rapl.py;ZeusdRAPLCPUcommunicates with Zeusd to interface with RAPL indirectly, removing the need for root privilegesRAPLCPUsinzeus/device/cpu/rapl.pyto utilizeZeusdRAPLCPUrather thanRAPLCPUif Zeusd is found on the expected socketzeusd/src/routes/cpu.rsfor checking if DRAM energy monitoring is availablezeusd/src/devices/cpu/mod.rsto support the above endpoint.zeusd/tests/cpu.rsto verify the endpoint works properly.