Expose DType size through the C api #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresy
reviewed
Nov 18, 2024
andresy
force-pushed
the
val/dtype_size
branch
from
5bfed91 to
18622ef
Compare
|
@davidkoski , you might now want to follow up on ml-explore/mlx-swift#158 |
I just need a tag to pick it up (along with the new API) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes
DType::size()through the C API, via a new function :mlx_array_dtype_sizeCurrently, the only way to do this is by using
mlx_array_itemsize(mlx_array arr)on an existing array.