Run extract-client-components as an esbuild plugin #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let current_dir = Sys.getcwd () in | ||
| let melange_target = Filename.concat current_dir target in | ||
| match capture_all_client_component_files_in_target melange_target with | ||
| | Ok manifest -> | ||
| render_manifest ~path manifest; | ||
| print_endline (render_manifest manifest); |
There was a problem hiding this comment.
Why do we need to print it?
There was a problem hiding this comment.
we print to the stdout so I can use the CLI from both:
- dune
(with-stdout-to (cli)) - esbuild
const content = execSync("cli"); Fs.writeFile(...)
Before the cli was writing the file, so from the outside had less control. That could be configured by a parameter, but the stdout should probably be the default
pedrobslisboa
approved these changes
Jan 20, 2025
davesnx
force-pushed
the
run-extract-as-esbuild-plugin
branch
from
bbccbcc to
54ee294
Compare
davesnx
added a commit
that referenced
this pull request
Jan 21, 2025
… into fix-render-to-lwt-stream * 'main' of github.com:ml-in-barcelona/server-reason-react: Run extract-client-components as an esbuild plugin (#199)
davesnx
added a commit
that referenced
this pull request
Jan 21, 2025
… into fix-render-to-lwt-stream * 'main' of github.com:ml-in-barcelona/server-reason-react: Run extract-client-components as an esbuild plugin (#199)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.