Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renderToStream #200

Merged
merged 29 commits into from
Jan 22, 2025
Merged

Fix renderToStream #200

merged 29 commits into from
Jan 22, 2025

Conversation

davesnx
Copy link
Member

@davesnx davesnx commented Jan 21, 2025

Ensure renderToStream can handle suspense + React.use + async components. Before toplevel wasn't awaiting and this PR solves this and handles errors.

@davesnx davesnx force-pushed the fix-render-to-lwt-stream branch from 2638785 to db96053 Compare January 21, 2025 12:45
@davesnx davesnx force-pushed the fix-render-to-lwt-stream branch from db96053 to d715f77 Compare January 21, 2025 12:56
@davesnx davesnx marked this pull request as ready for review January 21, 2025 13:03
@davesnx davesnx merged commit e824b24 into main Jan 22, 2025
2 checks passed
@davesnx davesnx deleted the fix-render-to-lwt-stream branch January 22, 2025 15:20
pedrobslisboa added a commit that referenced this pull request Jan 24, 2025
…essions

* origin/main:
  Fix renderToStream (#200)
  Run extract-client-components as an esbuild plugin (#199)
  delete rfc for manifest
  rewrite demo names for files
  Automatic bootstrap generation and fix some client props (#198)
  Generate boostrap.js file with client component refs (#193)
  feat: upgrade ocamlformat to 0.27.0 (#197)
  RSC syntax ppx (#196)
  Add test for promise value
  Add test for props as a children
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant