-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fairy adaptation - Draft Request #229
Open
ghost
wants to merge
18
commits into
ml-research:master
Choose a base branch
from
unknown repository
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… based on quick Edits
Great thanks for your on progress on this and your detailed TODO list. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Requesting this code to become a draft for an adaptation to accept all the Fairy-Stockfish variants. Including custom variants from the ini file
Main Ideas from my TODO file:
Adaptation of Liground for Fairy-Stockfish
List
Afterwards - variants.ini Workshop
Ambitious Plans
Graphics
Technical
Annoyances
Overall comments
This has been discussed on Fairy-Stockfish' discord, and would be great to have a generic GUI (when it comes to what ffish.js can handle or not) that could support all the variants there (including the custom ones written on the variants.ini file).
The ideas above are currently a dream that we all wish to come to life.
Current state with the code
At the time I wasn't aware of the VUE syntax on compilation time so it's only running on dev mode.
There are two additional buttons (simple ones) to link ffish.js to the variants.ini file defined by the user, and a refresh button (that needs to be done on our Fairy-Stockfish everytime it launches in order to refresh the variant list on that engine - important note it only uses the variants.ini file within the same directory of the engine)
The current code uses the merida pieces as default for all variants (a way of simplifying in order to test everything). I've added a lot of pieces (taking SVGs from both pychess and vchess) to the whole alphabet, including simple modifications using Inkscape for the promoted versions.
I've modified the code to accept custom promotions (I'm well aware that I've missed something in it) but overall it's working reasonably. Even accepts gating on seirawan.
The current pockets are not generic and have been unmodified (Xiangqihouse and Janggihouse even worked to a certain extent with some missing pieces)
Ideas already mentioned above:
Notes
I am terribly sorry for dragging this out for way too long. You are all awesome