RavenDB-22447 Incorrect "Connection String Not Defined" Error in SQL …

…ETL Task
ml054 · Jun 25, 2024 · 051b444 · 051b444
1 parent da80ca5
commit 051b444
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/...n.Studio/typescript/components/pages/database/tasks/ongoingTasks/panels/RavenEtlPanel.tsx b/...n.Studio/typescript/components/pages/database/tasks/ongoingTasks/panels/RavenEtlPanel.tsx
@@ -38,12 +38,12 @@ function Details(props: RavenEtlPanelProps & { canEdit: boolean }) {
     return (
         <RichPanelDetails>
             <ConnectionStringItem
-                connectionStringDefined={!!data.shared.destinationDatabase}
+                connectionStringDefined={connectionStringDefined}
                 canEdit={canEdit}
                 connectionStringName={data.shared.connectionStringName}
                 connectionStringsUrl={connectionStringsUrl}
             />
-            {connectionStringDefined && (
+            {data.shared.destinationDatabase && (
                 <RichPanelDetailItem label="Destination Database">
                     {data.shared.destinationDatabase}
                 </RichPanelDetailItem>

diff --git a/...o/typescript/components/pages/database/tasks/ongoingTasks/panels/ReplicationSinkPanel.tsx b/...o/typescript/components/pages/database/tasks/ongoingTasks/panels/ReplicationSinkPanel.tsx
@@ -38,12 +38,12 @@ function Details(props: ReplicationSinkPanelProps & { canEdit: boolean }) {
         <RichPanelDetails>
             <RichPanelDetailItem label="Hub Name">{data.shared.hubName}</RichPanelDetailItem>
             <ConnectionStringItem
-                connectionStringDefined={!!data.shared.destinationDatabase}
+                connectionStringDefined={connectionStringDefined}
                 canEdit={canEdit}
                 connectionStringName={data.shared.connectionStringName}
                 connectionStringsUrl={connectionStringsUrl}
             />
-            {connectionStringDefined && (
+            {data.shared.destinationDatabase && (
                 <RichPanelDetailItem label="Hub Database">{data.shared.destinationDatabase}</RichPanelDetailItem>
             )}
             <RichPanelDetailItem label="Actual Hub URL">{data.shared.destinationUrl ?? "N/A"}</RichPanelDetailItem>

diff --git a/...ven.Studio/typescript/components/pages/database/tasks/ongoingTasks/panels/SqlEtlPanel.tsx b/...ven.Studio/typescript/components/pages/database/tasks/ongoingTasks/panels/SqlEtlPanel.tsx
@@ -32,7 +32,7 @@ type SqlEtlPanelProps = BaseOngoingTaskPanelProps<OngoingTaskSqlEtlInfo>;
 function Details(props: SqlEtlPanelProps & { canEdit: boolean }) {
     const { data, canEdit } = props;
     const { appUrl } = useAppUrls();
-    const connectionStringDefined = !!data.shared.destinationDatabase;
+    const connectionStringDefined = data.shared.connectionStringDefined;
     const databaseName = useAppSelector(databaseSelectors.activeDatabaseName);
     const connectionStringsUrl = appUrl.forConnectionStrings(databaseName, "Sql", data.shared.connectionStringName);
 
@@ -44,7 +44,7 @@ function Details(props: SqlEtlPanelProps & { canEdit: boolean }) {
                 </RichPanelDetailItem>
             )}
             <ConnectionStringItem
-                connectionStringDefined={!!data.shared.destinationDatabase}
+                connectionStringDefined={connectionStringDefined}
                 canEdit={canEdit}
                 connectionStringName={data.shared.connectionStringName}
                 connectionStringsUrl={connectionStringsUrl}