-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch default runtime to tfjs
#140
Conversation
Everything looks good, however, I may have found a small issue with the But when I switch to this branch, there is an additional jitter / gltichiness to the results: This is on Mac OS with chrome. Anyone else seeing this? (gifs recorded at SFO |
Oh, the above is with blazepose, I'm not seeing the same issue with MoveNet actually (I don't think?). I'll have to test this more thoroughly later! |
I remember looking into this a while ago. The Perhaps we can implement it within ml5? I think |
Ah, ok, that makes sense! I think we could leave this to later especially since if someone needs it they could manually switch the runtime to mediapipe, is that correct? We should find a place to document this somewhere and perhaps open a new issue for future work / investigation? I don't think this needs to be completed before the upcoming soft launch. Also, the MoveNet model performs quite stably even without the smoothing. Hi webteam @QuinnHe @MOQN @myrahsa @alanvww regarding how to document the runtime choices and info about smoothing? Or perhaps this is something we put on a temporary wiki page and link from the documentation as it is not core to the beginner experience? |
Thanks Dan! Yes, we will take care of it after the soft launch. Just throw an idea for our future reference - maybe add |
Yes, I love this idea! I'm going to merge this so @QuinnHe let's open an issue in the docs repo for tracking later and @ziyuan-linn perhaps you can also open an issue in this repo for us to track the smoothing discussion as related to this and #69 and #129. |
This PR changes the default runtime of
handPose
,bodySegmentation
,faceMesh
, andbodyPose
totfjs
as discussed in #134.