BidderDeposit: Implement ClaimDepositSeller sub-validator
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euonymos
reviewed
Feb 19, 2024
| | -- ClaimDepositSeller errors | ||
| BidderDeposit'ClaimDepositSeller'Error'IncorrectValidityInterval | ||
| | BidderDeposit'ClaimDepositSeller'Error'MissingStandingBidInput | ||
| | BidderDeposit'ClaimDepositSeller'Error'StandingBidInputMissingToken |
There was a problem hiding this comment.
Can we be more specific in terms of which token we mean?
|
It's not clear which tokens we'd like to check and why, and the error is a bit ambiguous. That being said, we can merge it if you want to. |
errfrom
force-pushed
the
dshuiski/bidder-deposit-validator
branch
from
22bab3f
to
11ce32b
Compare
|
Do we still need this work @errfrom? |
|
@euonymos Yes, I'll get on this PR soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.