Update integration tests for new DynamicHMC versions #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethaxen
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Thanks @burtonjosh for the PR! LGTM, just one tiny whitespace change.
Relates #90
Codecov ReportBase: 87.95% // Head: 92.74% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
+ Coverage 87.95% 92.74% +4.79%
==========================================
Files 13 13
Lines 523 524 +1
==========================================
+ Hits 460 486 +26
+ Misses 63 38 -25
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Co-authored-by: Seth Axen <[email protected]>
sethaxen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that some of the integration tests weren't passing, looks like at some point the
chainfield has been renamed toposterior_matrixin AdvancedHMC. Also themean_and_mcsefunction was not working "per parameter" so I made some changes to fix that.