Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for refresh token absolute expiration time #604

Merged
merged 10 commits into from
Aug 15, 2024

Conversation

aristizabal95
Copy link
Contributor

This PR implements some logic that handles cases where an user hasn't logged in for longer than Auth0's absolute expiration time (30 days). Currently, if that happens the user encounters an error without much explanation of what happened or how to work through it. This PR checks if the error is related to expiration time, and if that's the case it explains to the user the problem and that they have to re-authenticate. It also automatically logs out the user.

Closes #583.

@aristizabal95 aristizabal95 added type: enhancement New feature or request component: client issues regarding the CLI labels Jul 15, 2024
@aristizabal95 aristizabal95 self-assigned this Jul 15, 2024
@aristizabal95 aristizabal95 requested a review from a team as a code owner July 15, 2024 16:33
Copy link
Contributor

github-actions bot commented Jul 15, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@hasan7n hasan7n had a problem deploying to testing-external-code August 9, 2024 18:29 — with GitHub Actions Failure
@hasan7n hasan7n had a problem deploying to testing-external-code August 9, 2024 18:29 — with GitHub Actions Failure
@hasan7n hasan7n temporarily deployed to testing-external-code August 9, 2024 19:08 — with GitHub Actions Inactive
@hasan7n hasan7n had a problem deploying to testing-external-code August 15, 2024 10:51 — with GitHub Actions Failure
@hasan7n hasan7n temporarily deployed to testing-external-code August 15, 2024 11:24 — with GitHub Actions Inactive
@hasan7n hasan7n merged commit 6186316 into mlcommons:main Aug 15, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: client issues regarding the CLI type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check Refresh token expiration on the client
2 participants