Skip to content

Fixes for llama 3.1 training #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes for llama 3.1 training #823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions large_language_model_pretraining/nemo/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ FROM ${NEMO_BASE_IMAGE} AS nemo-base-image
RUN pip uninstall transformers -y
RUN pip install transformers==4.47.1 blobfile==3.0.0
RUN pip install prettytable==3.12.0
RUN pip install toml==0.10.2
RUN pip install git+https://github.com/mlcommons/[email protected]

# setup workspace
Expand Down
4 changes: 2 additions & 2 deletions large_language_model_pretraining/nemo/pretrain_llama31.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ def slurm_executor(
gpus_per_node=devices,
mem="0",
exclusive=True,
gres="gpu:8",
packager=run.GitArchivePackager(subpath="large_language_model_pretraining/nemo", ref="HEAD"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please revert packager=run.GitArchivePackager(subpath="large_language_model_pretraining/nemo", ref="HEAD"), as well?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can however I don't understand who is able to run this. If you follow the instructions in the readme this will fail since the path is wrong.

Maybe if you move the Dockerfile to the root directory and build there then this will work, i.e.

cp Dockerfile ../..
cd ../..
docker build -t nemo .

gres=f"gpu:{devices}",
packager=run.GitArchivePackager(),
dependencies=dependencies,
)

Expand Down