-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widget Customizer Overhaul #1674
Merged
Merged
+655
−330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sjmarf
requested changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mlem/App/Views/Root/Tabs/Settings/InteractionBarEditor/InteractionBarEditorView+Views.swift
Outdated
Show resolved
Hide resolved
Mlem/App/Views/Root/Tabs/Settings/InteractionBarEditor/InteractionBarEditorView+Views.swift
Outdated
Show resolved
Hide resolved
Mlem/App/Views/Root/Tabs/Settings/InteractionBarEditor/InteractionBarEditorView+Logic.swift
Outdated
Show resolved
Hide resolved
Mlem/App/Views/Root/Tabs/Settings/InteractionBarEditor/InteractionBarEditorView+Views.swift
Outdated
Show resolved
Hide resolved
Mlem/App/Views/Root/Tabs/Settings/InteractionBarEditor/InteractionBarEditorView.swift
Outdated
Show resolved
Hide resolved
Loading status checks…
…tionBarEditorView+Views.swift Co-authored-by: Sjmarf <[email protected]>
Loading status checks…
…tionBarEditorView+Views.swift Co-authored-by: Sjmarf <[email protected]>
Co-authored-by: Sjmarf <[email protected]>
Loading status checks…
Sjmarf
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🔥
A few more dark mode fixes
Mlem/App/Views/Root/Tabs/Settings/InteractionBarEditor/InteractionBarEditorView+Views.swift
Outdated
Show resolved
Hide resolved
Mlem/App/Views/Root/Tabs/Settings/InteractionBarEditor/InteractionBarEditorView.swift
Show resolved
Hide resolved
Mlem/App/Views/Root/Tabs/Settings/InteractionBarEditor/InteractionBarEditorView+Views.swift
Outdated
Show resolved
Hide resolved
Mlem/App/Views/Root/Tabs/Settings/InteractionBarEditor/InteractionBarEditorView+Views.swift
Outdated
Show resolved
Hide resolved
Mlem/App/Views/Root/Tabs/Settings/InteractionBarEditor/InteractionBarEditorView+Views.swift
Outdated
Show resolved
Hide resolved
Mlem/App/Views/Root/Tabs/Settings/InteractionBarEditor/InteractionBarEditorView+Views.swift
Outdated
Show resolved
Hide resolved
Loading status checks…
…tionBarEditorView+Views.swift Co-authored-by: Sjmarf <[email protected]>
Loading status checks…
Co-authored-by: Sjmarf <[email protected]>
Loading status checks…
…tionBarEditorView+Views.swift Co-authored-by: Sjmarf <[email protected]>
Loading status checks…
…tionBarEditorView+Views.swift Co-authored-by: Sjmarf <[email protected]>
Loading status checks…
…tionBarEditorView+Views.swift Co-authored-by: Sjmarf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Per Slack, the final design will have a curated list of widgets that can be customized through a sheet. I'm saving that for a later PR, since this one is already quite large.
Description
Visual overhaul of the widget customizer:
Screen.Recording.2025-01-28.at.3.28.00.PM.mov
Implementation Notes
Most of the logic should be familiar, but I have made two key changes:
BarItem
struct. This represents an item on the bar, but has auuid
that is detached from the actualConfiguration.Item
it represents. This serves as a view identifier in the coreForEach(Array(barItems.enumerated))
that renders the interaction bar, resolving some animation misbehavior due to index-based identity. It also contains some members to help drive animations.Other implementation details of note:
onAppear
handler. This prevents bad animation behavior stemming from the combination of array insertion and animation without requiring a deliberate delay.BarItem
tracksancestor
, which is an optionalBarItem
. Ifancestor
is present, theonAppear
handler will animate the ancestor away. This allows smooth animations when moving items on the bar.onAppear
, letting us piggyback on the drop indicator display logic to handle hapticsMockTextView
barIconPadding
(was 4.24, is now 4.25)