Sharing options #1854
Open
Sharing options #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricBAndrews
approved these changes
Mar 11, 2025
Comment on lines
+62
to
+63
| "branch" : "sjmarf/sharing", | ||
| "revision" : "edfba5745c5ddbcd0137afd24687db85e168a32e" |
Comment on lines
+98
to
+111
| do { | ||
| print("START") | ||
| let client = ApiClient.getApiClient(url: url, username: nil) | ||
| let resolvedEntity = try await client.resolve(url: entity.actorId.url) | ||
| NavigationModel.main.shareInfo = .init( | ||
| url: resolvedEntity.url(), | ||
| actions: entity.shareSheetActions() | ||
| ) | ||
| ToastModel.main.removeToast(id: toastId) | ||
| print("END") | ||
| } catch { | ||
| print("ERROR", error) | ||
| ToastModel.main.removeToast(id: toastId) | ||
| handleError(error) |
| Section("Share links using...") { | ||
| Picker("Share links using...", selection: $linkSharingMode) { | ||
| ForEach(LinkSharingMode.allCases, id: \.self) { mode in | ||
| Text(mode.label) |
There was a problem hiding this comment.
nit
These should have conditional icons--"house," "signature," "questionmark.circle"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Relies on this MlemMiddleware PR.
Closes #639, closes #1395.
Settings -> Links -> Share Links
The default behavior is now to share from the user's instance rather than the author's instance as it was before.